Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance and memory for validation by caching XML Schema / DTD #572

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Improve performance and memory for validation by caching XML Schema / DTD #572

merged 1 commit into from
Oct 15, 2019

Conversation

angelozerr
Copy link
Contributor

Fixes #534

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

angelozerr commented Oct 9, 2019 •
edited
Loading

It works with simple case but a lot of tests are failed. It's definitely more hard than I though. I must work on again on this issue...

@angelozerr angelozerr changed the title Improve performance and memory by caching XML Schema / DTD Improve performance and memory for validation by caching XML Schema / DTD Oct 10, 2019
@angelozerr angelozerr force-pushed the grammar-cache branch 4 times, most recently from 4720cd2 to 36ef1cf Compare October 10, 2019 14:15
@angelozerr
Copy link
Contributor Author

angelozerr commented Oct 10, 2019 •
edited
Loading

After fighting with Xerces, I think (I hope) I have a cleaner implementation for validation cache.

@fbricon please restart your review I have modified a lot of thing.

@xorye @fbricon please play with this PR. We have a lot of tests but please test those following usecases:

  • XML file bind with XML Schema with schemaLocation. Update the XML Schema and check validation continue to work.

  • XML file bind with XML Schema A which includes a XMl Schema B with schemaLocation. Update the XML Schema B and check validation continue to work.

  • Do the same tests with XML file bound with XML Schema with noSchemaLocationNamespace.

  • Open a second XML file which bound an another XML Schema with noSchemaLocationNamespace. and tries if it works (It was a Xerces limitation that I figure it, I must write tests for that).

  • Do the same tests with XML file bound with DTD

@angelozerr angelozerr force-pushed the grammar-cache branch 2 times, most recently from 0b08f85 to 63c4751 Compare October 14, 2019 13:15
@angelozerr angelozerr marked this pull request as ready for review October 15, 2019 12:13
@angelozerr angelozerr force-pushed the grammar-cache branch 4 times, most recently from e88c43e to 012f1b4 Compare October 15, 2019 14:43
@fbricon fbricon merged commit f8a2c15 into master Oct 15, 2019
@fbricon fbricon mentioned this pull request Oct 15, 2019
Closed
@angelozerr angelozerr deleted the grammar-cache branch October 17, 2019 13:20
@angelozerr angelozerr restored the grammar-cache branch February 7, 2020 20:47
@angelozerr angelozerr deleted the grammar-cache branch March 12, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance and memory for validation by caching XML Schema / DTD
2 participants
@angelozerr @fbricon